-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX]web_responsive: fixed the issue of file viewer not display in form view. #3122
base: 17.0
Are you sure you want to change the base?
Conversation
fd7d4bc
to
d4a58bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cvinh please review. |
Thanks @parvezqureshi please include a setup by user if someone wants attachment to open automatically or not... default =False (thanks to @pedrobaeza ) Please remove the screenshots, there are personal data in them... I think the reviewers understood the purpose |
7fa550c
to
19d2832
Compare
@@ -70,6 +70,7 @@ | |||
<data> | |||
<field name="action_id" position="after"> | |||
<field name="is_redirect_home" invisible="action_id" /> | |||
<field name="display_file_viewer" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems it has an incorrect indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you :
- improve the README explaining this new functionality
- change your commit comment with [IMP] instead of [FIX]
web_responsive/models/res_users.py
Outdated
@@ -31,6 +31,7 @@ class ResUsers(models.Model): | |||
store=True, | |||
readonly=False, | |||
) | |||
display_file_viewer = fields.Boolean() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a help to explain what this field does
cc @vehi-invitu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
19d2832
to
cabeea5
Compare
cabeea5
to
725185e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The attachments of customer invoices appear automatically (see screenshot). When we install oca/web/web_responsive, the attachments do not appear automatically (see screenshot). This is on a computer screen of course.